PecanProject / bety

Web-interface to the Biofuel Ecophysiological Traits and Yields Database (used by PEcAn and TERRA REF)
https://www.betydb.org
BSD 3-Clause "New" or "Revised" License
16 stars 38 forks source link

Pagination issue in BETY web interface when searching species #525

Closed serbinsh closed 6 years ago

serbinsh commented 7 years ago

@gsrohde @dlebauer

Unfortunately I didn't save an example of the correct behavior on the modex.bnl.gov version of BETY before I updated it to the latest version (4.18) but this was not an issue in the previous release. So note this seems like a new issue. I also don't know where else this may be an issue, I discovered it when searching for species to add to a PFT through the BETYdb web front end

Basically, if you search for a genus/species, such as Salix in the "Listing Species" search bar, you will get a list of hits back. Sometimes this list is multiple pages long. In the previous version of BETY if you selected next or click on one of the other numbered pages it would show you the next set of species associated with that search. Say you clicked on page 3 it would show you the Salix species listed on page 3 of the search.

However it seems in 4.18 it instead now just lists the species already added into the PFT when you go to the next page. In other words, instead of continuing to show you the search results it instead shows you the species in the PFT, like it looses track of the search past page 1?

Here is an example searching Acer

screen shot 2017-07-21 at 10 36 07 am

You go to the next page and now it shows you all the species in that particular PFT?

screen shot 2017-07-21 at 10 35 33 am
gsrohde commented 7 years ago

I found a version BETYdb from June 30, 2015 running of our development server, and this problem exists there as well. So I don't think it's a recent problem.

That said, I'll look into fixes.

gsrohde commented 7 years ago

@serbinsh I think this is fixed. If you pull the latest version of master (and do touch tmp/restart.txt in the Rails root directory, if needed), the searches should work correctly.

serbinsh commented 7 years ago

OK, when I have a moment tonight I will give that a try

S

On Jul 24, 2017, at 2:17 PM, Scott Rohde notifications@github.com<mailto:notifications@github.com> wrote:

@serbinshhttps://github.com/serbinsh I think this is fixed. If you pull the latest version of master (and do touch tmp/restart.txt in the Rails root directory, if needed), the searches should work correctly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PecanProject/bety/issues/525#issuecomment-317571071, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC7N6YKJkIpRRKTefHyWz98Lh9GFuwpsks5sRRfvgaJpZM4OgMEr.

serbinsh commented 7 years ago

@gsrohde that recent push fixed the issue on modex, thanks! I recommend the update for BETYdb.org as well...since that is where we created the PFT initially...but I suppose all DBs should run that simple update.

gsrohde commented 7 years ago

@serbinsh It will go into the next release, which will be "whenever" unless someone tells me this is urgent, and then I will prioritize it.

gsrohde commented 6 years ago

Resolved by release 4.19. Closing.