Trait/entity notes don't get populated through Bulk Upload Wizard

[serbinsh]

In two different instances, I have noticed that properly formated .csv files uploaded through the Buld Upload Wizzard don't have their notes fields loaded into BETYdb?

This is for data related to citations

bety/citations/2000000017

and

bety/citations/2000000021

Both of which had a notes column populated with information that I was hoping to keep with the observations.

[serbinsh]

bety=> select notes from traits where entity_id = 2000000181;
 notes
-------

(5 rows)

[serbinsh]

bety=> select mean,variable_id from traits where entity_id = 2000000181;
 mean | variable_id
------+-------------
 9.59 |          15
  2.1 |          10
   48 |          11
 22.8 |          31
 2.19 |         566
(5 rows)

[serbinsh]

@gsrohde @dlebauer could we revisit this? There are some datasets where I would like to keep the notes field as it contains information, such as plot number or lat/long for the measurement. But as I mentioned, the notes field is recognized in the upload but after upload the notes are empty

[serbinsh]

Perhaps it wasnt the intention to keep the notes field?

[serbinsh]

For example

[gsrohde]

@serbinsh This was caused by a subtle but easy-to-fix bug introduced in March in release 4.15. I will try to do a new release soon with this fixed.

[gsrohde]

P.S. The notes always go into traits.notes, not entities.notes. There is no way to populate the entities.notes column via the Bulk Upload Wizard. This could possibly be changed if there is some agreement on how this should ideally work.

[gsrohde]

Pull request #549 fixes this.

[serbinsh]

Thanks @gsrohde! It looks like the checks failed, do we need to modify anything before we can merge this fix?

[gsrohde]

@serbinsh If you mean the Travis checks, this is a known problem; see #544. When I run rspec on my own copy, none of the tests fails.

[serbinsh]

OK. Does that mean we can merge your PR so that I can try the upload again? @gsrohde @dlebauer

[gsrohde]

I'm waiting for one of the reviewers—@max-zilla, @robkooper, or @dlebauer—to approve the PR before I merge it. I suppose you could check out the bulk_upload_notes_fix branch to your deployment copy in the meantime.

[gsrohde]

@serbinsh This is merged now, but I haven't done a new release yet. If you don't want to wait, you could just pull the latest changes from master—there aren't any new database migrations since the last release.

[serbinsh]

Ok. Thanks! I will likely pull the changes in master and then restart.

Sent from my iPhone

On Nov 6, 2017, at 2:58 PM, Scott Rohde notifications@github.com<mailto:notifications@github.com> wrote:

@serbinshhttps://github.com/serbinsh This is merged now, but I haven't done a new release yet. If you don't want to wait, you could just pull the latest changes from master—there aren't any new database migrations since the last release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PecanProject/bety/issues/533#issuecomment-342267581, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AC7N6XO1Y2aL0y6DkPEhsh4KIArM3cJ3ks5sz2S6gaJpZM4PKTIE.

[serbinsh]

Just to confirm, I will just pull the latest master branch and touch tmp/restart to load the updated code, correct?

[gsrohde]

touch tmp/restart.txt

[serbinsh]

Thanks

[gsrohde]

Fixed by release 4.20. Closing.