search

PecanProject / pecan-documentation

PEcAn Documentation (maintained by robots)
http://pecanproject.github.io/documentation.html
3 stars 5 forks source link

Links not working bug fixed #8

Closed mustafaazad03 closed 1 week ago

mustafaazad03 commented 1 year ago

Issue solved #14

mdietze commented 1 year ago

@robkooper is it safe to merge these fixes, or will they cause a conflict since the contents of this repo are generated programmatically from the pecan repo. I'm particularly worried about the develop branch.

@Mustafa-Azad025 either way, you'll definitely want to introduce this fix in the pecan repo itself otherwise future versions won't include this change.

mustafaazad03 commented 1 year ago

Hey @mdietze , Thanks for reply , so how will I do that can u pls guide !

mdietze commented 1 year ago

@Mustafa-Azad025 the documentation is machine generated from the files in the book_source folder in the pecan repository. So, for example, if you want to fix something in develop/index.html in the webpage you need to fix it in https://github.com/PecanProject/pecan/blob/develop/book_source/index.Rmd (i.e. the index.Rmd file on the develop branch)

mustafaazad03 commented 1 year ago

Ok , thanks I will try this.

mustafaazad03 commented 1 year ago

Hi @mdietze , I cloned the Pecan repo, however I'm not sure what to change in that file.

dlebauer commented 1 year ago

@Mustafa-Azad025 you should be able to find the same links in the .Rmd file, eg the one to join pecan slack is here: https://github.com/PecanProject/pecan/blob/e348c8981320d29bb96c4164027ad49eb9d806cd/book_source/index.Rmd#L47

mustafaazad03 commented 1 year ago

Oh Ok thank you so much for clarifying, I will make that correction.

mustafaazad03 commented 1 year ago

@Mustafa-Azad025 you should be able to find the same links in the .Rmd file, eg the one to join pecan slack is here: https://github.com/PecanProject/pecan/blob/e348c8981320d29bb96c4164027ad49eb9d806cd/book_source/index.Rmd#L47

In this I changed just the target of URL to parent i.e the link was correct but problem is of redirection of link --> image

So how can i find in pecan repo files ?

dlebauer commented 1 year ago

Did you look here? https://github.com/PecanProject/pecan/blob/e348c8981320d29bb96c4164027ad49eb9d806cd/book_source/index.Rmd#L47

mustafaazad03 commented 1 year ago

Did you look here? https://github.com/PecanProject/pecan/blob/e348c8981320d29bb96c4164027ad49eb9d806cd/book_source/index.Rmd#L47

yes, I look there as well.