PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
203 stars 235 forks source link

Enable BioCro tests to run in the web interface #1266

Closed dlebauer closed 6 years ago

dlebauer commented 7 years ago

Description

I am assuming that

.../web/workflow.R --settings pecan64.biocro.xml

works on the Virtual Machine.

The next step is to enable BioCro to work in the web interface -

I believe there are two steps to enabling this

  1. get the location of the binary executable (pointbiocro.Rscript) from BETYdb given the model name in settings (probably already works)
  2. hook into the met workflow.

I think 2 will be the bulk of the work

Completion Criteria

infotroph commented 7 years ago

Test instance at 34.204.88.90 incorporating the changes from #1295 -- currently works with pecan64.biocro.xml and also in the browser with Bondville test met data and at least some PFTs (Miscanthus and Sorghum OK, c4grass fails), as long as you:

  1. Specify an end date no later than 2004-12-30, or more precisely don't specify a 366-day year. Does BioCro handle leap days?
    1. Choose "edit pecan.xml" and change the ensemble variable from NPP to one of the variables returned by model2netcdf.BIOCRO.R: TotLivBiom, RootBiom, StemBiom, Yield, Evap, TVeg, LAI.
dlebauer commented 7 years ago

Does BioCro handle leap days?

I don't think BioCro cares about leap days ... it just runs along the met data.

PR https://github.com/PecanProject/pecan/pull/1312 should add NPP to BioCro output, though I haven't tested it.

infotroph commented 7 years ago

@dlebauer OK to close this?

dlebauer commented 7 years ago

@infotroph If it would take less than a few hours to work with NARR and CRUNCEP, could you please do that?