PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
203 stars 235 forks source link

Standard/CF variable names for litter #1487

Open annethomas opened 7 years ago

annethomas commented 7 years ago

Litter output variables currently don't have a satisfactory standard naming system. They should match CF.

Description

@mdietze wants the DALEC-associated variables LeafLitter and WoodyLitter and another version, leaf_litter (in BETY) to be changed to reflect CF names litter_carbon_flux and litter_carbon_content. We also want to incorporate CF names subsurface_litter_carbon_content and surface_litter_carbon_content into the hierarchy. This is related to issue #1442 and hierarchical grouping of pool variables. @tonygardella you'll need to change the standard output table to include the cf variables, and we'll need to rename the variables in BETY where possible and fix the models that use the DALEC output names.

annethomas commented 7 years ago

@mdietze A few follow-up questions:

  1. Since the DALEC names are split into Leaf and Wood, do we want to rename the variables using the CF convention, so leaf_litter_carbon_flux and wood_litter_carbon_flux, rather than changing something to the exact CF name?
  2. Then do we also want the aggregated variable litter_carbon_flux as a new variable?
  3. Is litter_carbon_content replacing leaf_litter in BETY? Does that need to be split into leaf/wood at some point?
  4. Are the surface and subsurface variables also new variables to be added?
mdietze commented 7 years ago
  1. wouldn't a split of the litter flux be between leaf and fine root? That seems like a find distinction at the next level of the hierarchy. Woudn't the wood flux be CWD?
  2. yes
  3. yes, but that will take checking the code and the trait data before you change the names and units. litter_carbon_content is already being split between surface and subsurface.
  4. yes
annethomas commented 7 years ago

@mdietze That's right, I remember talking about coarse woody debris. It's named WoodyLitter in the table but I'm not sure exactly what it means. There's a CF name wood_debris_carbon_content, but no flux. Do we want to make wood_debris_carbon_flux?

mccabete commented 7 years ago

@mdietze Where in the code would I find where things are already being summed up? the model2netcdf?

annethomas commented 7 years ago

There's also a RootLitter variable, kg C m-2 s-2, in BETY. s-2 seems odd

dlebauer commented 7 years ago

Is it possible to use the standard name fields instead of changing the variable name / units in BETYdb? I think we added those fields for exactly this reason. On Fri, Jun 23, 2017 at 1:47 PM annethomas notifications@github.com wrote:

There's also a RootLitter variable, kg C m-2 s-2, in BETY

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PecanProject/pecan/issues/1487#issuecomment-310744571, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcX55yf1V_eb5EfrTYjwhud8LINqWH7ks5sHAhXgaJpZM4ODzNT .

mdietze commented 7 years ago

@dlebauer it's possible to use standard name in places, but it's also true that we sometimes come across names that could have been better thought out. For example, we have one variable names leaf_litter and another named LeafLitter. One is a flux, the other is a pool. One is g DM, the other is kg C. I looked at this and felt that these names and units really do need to change to be clear and consistent, and in this case there are CF names for these that are very clear (litter_carbon_flux and litter_carbon_content) and have consistent units. If this was just internally we could deal with standard name look-ups (though I do think it could make the code really ambiguous if we're using these as internal variable names), but we're also about to add these to the model input and output standards, which just feels like shooting ourselves in the foot.

mccabete commented 7 years ago

Here's a first pass at making this happen just using MSTMIP variables and the model outputs that are summed into MSTMIP variables in model2netcdf.

Hierarchical structure of variable names .pdf Here's also a link to an online version, but you have to log into Lucid Chart.

Second step would be: Expanding this hierarchy to include all of the variables that can be reported from models (For FATES + CLM that is a little intimidating)

Insuring that BETY variables are either included in this hierarchy or a removed for being redundant.

Also integrating paleon variables into the top layer of the hierarchy image

annethomas commented 7 years ago

for reference, Clark et al. 2001 NPP paper: NPP includes "aboveground biomass increment, fine litterfall, aboveground losses to consumers, emissions of biogenic volatile organic compounds (BVOCs), aboveground losses of leached organic compounds, net increments in biomass of coarse and fine roots, dead coarse and fine roots, root losses to consumers, root exudates, carbohydrates exported by plants to their mycorrhizal or nodule symbionts, and any net increases in stores of nonstructural carbohydrates"

annethomas commented 7 years ago

NPP breakdown.pptx A diagram

annethomas commented 7 years ago

Here's FIA's field measurement protocol: https://www.fia.fs.fed.us/library/field-guides-methods-proc/docs/2016/core_ver7-1_10_2016-opt.pdf

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 365 days with no activity.