PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
203 stars 235 forks source link

split database tag in pecan.xml #152

Closed robkooper closed 10 years ago

robkooper commented 10 years ago

Should have a bety entry as well as fia entry.

<database>
  <bety>
    <user>...</user>
    ...
  </bety>
  <fia5>
    ...
  </fia5>
</database>
robkooper commented 10 years ago

The other option is to have to fields, the advantage is that we can store more bety related stuff in the bety tag, such as write to database, as well as a username/password/key combination.

<bety>
  <database>...</database>
  <userid>...</userid>
  <password>...</password>
  <write>TRUE</write>
</bety>
<fia5>
  <database>...</database>
</fia5>
mdietze commented 10 years ago

I prefer the first approach, since it makes it much more clear to a novice that these are databases and the internal tags are that same. That said, we can definitely include the db-specific tags nested within each (e.g. 's ).

For the FIA I'd make the tag not so that we don't have to change all the tags when the next version is released (just the specific dbname). Just in my time working with it, I've had to work with four major FIA releases and numerous minor versions.

robkooper commented 10 years ago

Split database in two subsections, bety and fia. Moved bety$write to be part of the database$bety section, updated documentation at: https://github.com/PecanProject/pecan/wiki/PEcAn-Configuration#database_access