search

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
200 stars 231 forks source link

Adapting met2model Functions for New Data Sources #2003

Open Luke-Dramko opened 5 years ago

Luke-Dramko commented 5 years ago

Description

Many conversion functions in the met2model stage of data processing make assumptions about the file names they are pulling data from. In particular, these functions expect files in the format:

MET.YYYY.nc

where MET is the name of the meteorological data product and YYYY is the 4-digit year.

Some newer data products, including NOAA GEFS, have more specific or otherwise different file names. In order to enable processing of data using these functions, each met2model conversion function must be updated individually for this purpose.

met2model.SIPNET has been updated for NOAA GEFS and other new data sources.

Context

Possible Implementation

met2model.SIPNET has 2 additional arguments: year.fragment and in.data.file, which default to FALSE and NULL, respectively. If statement handle the cases when they are TRUE and of the character data type. Currently, these arguments are only used if forecast=TRUE, that is, if TRUE exists in the data product's registration xml.

Note that the output file name may also have to be changed as well in order to reflect the specificity of the data.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 365 days with no activity.

infotroph commented 4 years ago

Unstaling. Not high priority, but it would still be great to fix this to work more cleanly in the general case.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 365 days with no activity.