Open ashiklom opened 5 years ago
Possibly related to #1343, which was closed by @dlebauer without comment.
@ashiklom I mean, @dlebauer closed it by merging my PR that claimed it was fixed, so I don't think this is too heavily on him.
Proposed resolution:
delta <- stats::median(diff(all.dates$date), na.rm = TRUE)
...
if (end.date > (max(all.dates$date) + delta)) { ...
...our met files are all regularly spaced modulo missing data, yeah?
This issue is stale because it has been open 365 days with no activity.
This issue is stale because it has been open 365 days with no activity.
Bug Description
Based on this conversation on PR #2273.
Basically,
data.atmosphere::load.cfmet
throws an error like the following when given CRUNCEP input (this case is thrown frommet2model.BIOCRO
).The issue is that this code block (
load.cfmet
) expects the end of the year to be 23:59 on December 31, but the last data point for 3-hourly met like CRUNCEP is at 21:00.To Reproduce
Remove the
skip
statement fromtest.met2model.R
for BIOCRO (once #2273 is merged); then, rundevtools::test("models/biocro")
.