PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 234 forks source link

Don't use `testthat` inside of functions #2987

Closed Aariq closed 1 year ago

Aariq commented 2 years ago

Bug Description

The testthat package is made for unit testing, not use inside of functions. testhat functions appear in at least a couple of places:

These should be replaced with calls to stopifnot() or something from the assert or assertthat packages

Aariq commented 2 years ago

Other places:

Aariq commented 2 years ago

Partially fixed by #3016

Sarthakaga15 commented 1 year ago

Hi @Aariq , can I please work on this issue?

Aariq commented 1 year ago

Hi @Aariq , can I please work on this issue?

Just be sure to look at #3067 so you're not duplicating efforts. I think most of the stragglers are being handled in that PR.

moki1202 commented 1 year ago

@Sarthakaga15 there's one more instance that you can work on, in ./models/ed/R/write_ed_veg.R. if you need any further help on this, let me know.