PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 235 forks source link

Change argument `env.samples` in `get.emsemble.samples()` to optional #2994

Closed ecamo19 closed 1 year ago

ecamo19 commented 2 years ago

Changes argument env.samples in the get.ensembles.samples() function from required to optional

env.samples is a required argument in the get.ensemble.samples function. However not all the time these env samples are available. Thus, is necessary to change this argument to optional in case a user wants to get the ensemble samples without taking into account the env.samples.

Description

The argument changes from required to optional, if the argument env.samples is NOT null the env.samples object will be appended to the pft.samples object.

Motivation and Context

With the change proposed it will be possible to get ensemble samples without having the env.samples object

Review Time Estimate

Types of changes

Checklist:

Aariq commented 2 years ago

Was your issue fixed by https://github.com/PecanProject/pecan/pull/3005 ? If so, does this PR still need review?

Aariq commented 1 year ago

I converted this to a draft. I may pick this up and implement some of my suggestions later.