remove leftover link to udunits2 package

infotroph commented 2 years ago

R checks for utils now complain if run on a system that doesn't have udunits2 installed. Fixed by rewording to point to new wrapper instead.

Description

Motivation and Context

Review Time Estimate

[ ] Immediately
[ ] Within one week
[ ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

nanu1605 commented 2 years ago

@infotroph I uninstalled udunits2 from my Rstudio and ran R CMD check for utils package and it does not show any dependency warning regarding udunits2

nanu1605 commented 2 years ago

CHANGELOG.md already updated, tests added to cover the changes, all new and existing checks are passing

nanu1605 commented 2 years ago

@infotroph when I searched for udunits2 in the whole pecan except the .log files, there are some places where udunits2 is still used, mostly in the shiny and scripts folder. Should we replace them too?

infotroph commented 2 years ago

@nanu1605 Good catch! Yes, let's review all the remaining usages.

PecanProject / pecan