PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 235 forks source link

fixes issues #2955 and #2959 #3010

Closed hangyakuzero closed 2 years ago

hangyakuzero commented 2 years ago

Description

Recently @robkooper changed the way the docker install works so that pecan is reached from http://pecan.localhost/ instead of http://localhost:8000/. I've made the changes in the documentation in https://github.com/PecanProject/pecan/pull/2935, but there are still instances of "localhost:8000" in tests, shell scripts,etc. I have made the changes accordingly. Also I have changed the regex pattern as required.

this fixes issue #2955 and #2959

Review Time Estimate

Types of changes

Checklist:

infotroph commented 2 years ago

This still won't catch jobids without a literal space before them (e.g. my old frenemy "ondemand52.aci.ics.psu.edu.568420642 submitted"), but my sense is that in practice every default involving qsub should be thought of less as a value that will work for most people and more as an example of how to specify your own value when the default inevitably fails on your system. Therefore I support merging this as it is.