only open one connection to BETY instead of one per PFT (#2967) - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

202 stars 234 forks source link

only open one connection to BETY instead of one per PFT (#2967) #3018

Closed Aariq closed 2 years ago

Aariq commented 2 years ago

Description

Motivation and Context

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x] When possible

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[x] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Aariq commented 2 years ago

Looks like at least in the case of ED2, write.ensemble.configs(), which is called by run.write.configs() also opens a connection to BETY. Probably only the outer connection should do this and pass the connection to the inner function. Maybe a separate PR though?