Closed helge22a closed 2 years ago
noting from PEcAn meeting that @infotroph needs to check the impacts of this change on make, etc before pulling.
Places I checked for build tool assumptions that might break on this name change:
PEcAn.all
? ✅: They match any package with "PEcAn" in its name and don't check for the dotMakefile
? ✅: Works entirely on directory names, not package namesscripts/
folder? I manually reviewed all contents to confirm...
^PEcAn.
Technically this still works because the dot gets interpreted as a wildcard here, but it's misleading .github/workflows
? ✅: all the package-specific steps are handled by Make, which I checked already. docker/
? ✅: all the package-specific steps are handled by Make, which I checked already.
Description
Reverting commits made in PR #2927 to remove "." from assim.sequential package. @infotroph @mdietze @serbinsh @DongchenZ @Qianyuxuan
I am not sure why GitHub is including other commits not related to ones I just made on this new branch, but I cannot figure out how to get rid of them?
Motivation and Context
Nimble throughs an error with package names containing "."
Review Time Estimate
Types of changes
Checklist: