PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 234 forks source link

Shifting minimize.GP.R from emulator to assim.batch #3027

Closed nanu1605 closed 1 year ago

nanu1605 commented 2 years ago

To remove the circular dependency between emulator and assim.batch

This replaces #3017 , which accumulated enough conflicts that it was easier to redo the changes in a new branch.

mdietze commented 1 year ago

looks like you have a number of namespace issues. Looks like most will be quick to resolve.

 checking R code for possible problems ... NOTE: get_ss: no visible global function definition for 'rnorm'
  checking R code for possible problems ... NOTE: gpeval: no visible binding for global variable 'splinefuns'
  checking R code for possible problems ... NOTE: gpeval : <anonymous>: no visible binding for global variable 'splinefuns'
  checking R code for possible problems ... NOTE: gpeval: no visible binding for global variable 'ytrend'
  checking R code for possible problems ... NOTE: is.accepted: no visible global function definition for 'runif'
  checking R code for possible problems ... NOTE: mcmc.GP: no visible global function definition for 'rnorm'
  checking R code for possible problems ... NOTE: mcmc.GP: no visible global function definition for 'p'
  checking R code for possible problems ... NOTE: mcmc.GP: no visible binding for global variable 'jmp'
  checking R code for possible problems ... NOTE: minimize.GP: no visible global function definition for 'median'
  checking R code for possible problems ... NOTE: minimize.GP: no visible binding for global variable 'median'
  checking R code for possible problems ... NOTE: minimize.GP: no visible global function definition for 'nlm'
  checking R code for possible problems ... NOTE: minimize.GP: no visible binding for global variable 'splinefcns'
  checking R code for possible problems ... NOTE: to your NAMESPACE file.
infotroph commented 1 year ago

@nanu1605 I'll have some time this weekend -- any objection if I tag in and resolve the namespace complaints?

nanu1605 commented 1 year ago

@infotroph Let's resolve the namespace problem

mdietze commented 1 year ago

Thanks @nanu1605 and @infotroph