Minor change to generate deps script - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

202 stars 234 forks source link

Minor change to generate deps script #3029

Closed Aariq closed 2 years ago

Aariq commented 2 years ago

Description

Removes an unnecessary lapply()

Motivation and Context

Review Time Estimate

[ ] Immediately
[ ] Within one week
[ ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Aariq commented 2 years ago

Done with this now, but I'll leave it open in case you want to merge the minor change I made. Feel free to close also.

infotroph commented 2 years ago

Yes, let's keep the change! Hooray for using build-in vectorization where it's available to us.