PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 234 forks source link

set defaults for new ED2IN vars #3033

Closed Aariq closed 1 year ago

Aariq commented 2 years ago

Description

Sets some arbitrary defaults for new variables in ED2IN file. These are required for the ED2IN file to be parsed, but I don't think they actually are used. The ED2IN template says "These variables are used to define the additional soil properties needed for SOIL_HYDRO_SCHEME=2." and in this ED2IN file I've set SOIL_HYDRO_SCHEME=0.

Defaults came from googling the description of the variable with the word "typical" and "soil".

Also fixes a mistake in #3035 that added new variables not in the ED2IN template after the $END tag.

Motivation and Context

Required variables for development version of ED2 to run.

Review Time Estimate

Types of changes

Extremely unlikely to break anything, and I can't test if it works until the PR gets merged and the docker container gets built by GitHub actions.

Checklist:

Aariq commented 2 years ago

Installed on Welsh server and tested with development version of ED2. Both supplying the new template and supplying new tags with pecan.xml work.