Fix bug in writing new tags to ED2IN - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

202 stars 234 forks source link

Fix bug in writing new tags to ED2IN #3035

Closed Aariq closed 2 years ago

Aariq commented 2 years ago

Description

Closes #3034. Now prints informative error if there are tags not in the ED2IN template and it adds them to the end of the output ED2IN file.

Motivation and Context

This change is consistent with what is expected from reading the PEcAn documentation

Review Time Estimate

[ ] Immediately
[x] Within one week
[ ] When possible

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[x] My name is in the list of CITATION.cff
[x] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

dlebauer commented 2 years ago

Awesome thanks for including tests!!!