find fqdn across platforms - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

202 stars 230 forks source link

find fqdn across platforms #3058

Closed dlebauer closed 1 year ago

dlebauer commented 1 year ago

Description

Add as.character(Sys.info()["nodename"]) if no env variable FQDN and hostname -f return empty strings.

Motivation and Context

hostname doesn't work on Windows. Fixes #3044

Perhaps a simpler option

replace function with fqdn <- function() as.character(Sys.info()["nodename"])

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x] When possible

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[x] My name is in the list of CITATION.cff
[x] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.