Closed Qianyuxuan closed 1 year ago
The code is outdated, @Qianyuxuan you probably need to do a git pull from PEcAn develop branch and then update the code accordingly.
@Qianyuxuan key step is to resolve this conflict https://github.com/PecanProject/pecan/pull/3059/conflicts
@Qianyuxuan please respond to the issues your collaborators have raised in place, rather than deleting this branch and opening a second, virtually identical PR. The PR review process does not function if your collaborators cannot see what has changed from version to version and how you have responded.
@dlebauer looks like @Qianyuxuan responded to your change request. Could you confirm and "approve" so this can be merged?
@dlebauer Sorry, just realized I didn't reply to you. The conflict has been resolved and the "select" function has been updated.
@Qianyuxuan now that Github Actions is working for us again, I was hoping that you could resolve the conflicts in this PR so that we can pull it in finally
@mdietze Hi Mike, just to let you know I have resolved the conflict. Please let me know if there are other issues.
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: