PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 230 forks source link

Fix for #2968 to add `write` argument to `get.trait.data()` and friends #3065

Closed Aariq closed 1 year ago

Aariq commented 1 year ago

Description

Adds a write argument to get.trait.data() and get.trait.data.pft() and changes runModule.get.trait.data() and get.trait.data() to correctly pass the write argument. Minor fixes to documentation, code formatting, and fixed one unrelated check warning in site.pft.link.settings()

Motivation and Context

Closes #2968

Review Time Estimate

Types of changes

Checklist:

Aariq commented 1 year ago

Should I add a NEWS.md to the settings package and bump the version?

Aariq commented 1 year ago

Looks like test coverage for these functions is 0%, but I did install this PR and test with an existing run and the behavior is correct. Not sure how to write tests for database stuff, but I can try if you'd like.