search

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 230 forks source link

`model2netcdf.ED2()` gives incorrect output when PFT is in settings but not in ED output #3068

Closed Aariq closed 1 year ago

Aariq commented 1 year ago

Bug Description

This is a weird edge case, but should be handled. I did a run with IED_INIT_MODE=6 where the only pft in the history files was pft 9. In pecan.xml I included PFT 9 and 1. The "-E-" files output by ED2 only have pft 9 in them, but the .nc file output by model2netcdf.ED2() have both pfts and the data are super wonky (e.g. negative ABG).

Expected behavior

Should probably just error ("PFTs found in settings not in output!!"). Possibly this is just a warning and it continues, using only the settings PFT that matches the .h5 files.

Aariq commented 1 year ago

So, turns out this is not a thing you're supposed to do (put PFTs in pecan.xml that are not in chort files.). Closing this for now at least