search

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 231 forks source link

PEcAn.remote::remote.copy.to and from don't check that `host` argument isn't NULL #3107

Closed Aariq closed 1 year ago

Aariq commented 1 year ago

Bug Description

Made a typo and did remote.copy.to(host = settings$hots, ...) and rsync failed with uninformative error. It ended up running this:

rsync '-a' '-q' '/path/to/src' ' :/path/to/dst'

instead of

rsync '-a' '-q' '/path/to/src' ' username@host:/path/to/dst'

Expected behavior

PEcAn functions should fail early if host is NULL with informative message.

meetagrawal09 commented 1 year ago

I would like to work on this issue.