Check for `host` being `NULL` - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

202 stars 231 forks source link

Check for `host` being `NULL` #3108

Closed meetagrawal09 closed 1 year ago

meetagrawal09 commented 1 year ago

Description

PEcAn functions will fail early if host is NULL with informative message when making a call to remote.copy.to() This PR fixes #3107

Review Time Estimate

[ ] Immediately
[ ] Within one week
[X] When possible

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

meetagrawal09 commented 1 year ago

@Aariq can you please have a look at this one.

meetagrawal09 commented 1 year ago

@infotroph Anything more that we can check as part of the conditions added ?