PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 235 forks source link

Moved `regrid` and `grid2netcdf` to `data.remote` #3139

Closed meetagrawal09 closed 1 year ago

meetagrawal09 commented 1 year ago

Description

This PR fixes #2913 Aims to remove GDAL dependency for PEcAn.utils

Review Time Estimate

Types of changes

Checklist:

meetagrawal09 commented 1 year ago

Yes, also an update to Rcheck_reference.log is needed. Will make the required updates.

meetagrawal09 commented 1 year ago

@mdietze , PEcAn.utils::need_packages is a required function in regrid, but is not exported from the PEcAn.utils package. Should I consider exporting it from PEcAn.utils or remove the function call from regrid ?

mdietze commented 1 year ago

Yeah, I'd export need_packages