PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
200 stars 231 forks source link

Updated `write.configs.ed` to throw an error if `revision` not specified #3156

Closed meetagrawal09 closed 1 year ago

meetagrawal09 commented 1 year ago

Description

This PR fixes #3142

Review Time Estimate

Types of changes

Checklist:

meetagrawal09 commented 1 year ago

@mdietze, @Aariq should I turn to using logger.error in-place of logger.severe for the fix ?

mdietze commented 1 year ago

I think either error or severe is fine. We tend to lean towards error over severe in cases where there are multiple ensemble members and/or locations and only a subset might be failing (i.e. we don't want to kill other ensemble members over an error in just one).

If this fix eliminates the dependency on PEcAn.DB then the DESCRIPTION and make should also be updated