Removing Dependency on `trait.lookup`

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

202 stars 235 forks source link

Removing Dependency on `trait.lookup` #3165

Closed meetagrawal09 closed 1 year ago

meetagrawal09 commented 1 year ago

Description

This PR tries to address #729 and #1747

Review Time Estimate

[ ] Immediately
[ ] Within one week
[X] When possible

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

meetagrawal09 commented 1 year ago

@mdietze, this PR is aimed to address only those functions where removing dependency of trait.lookup by making trait variable a dataframe with id, figid and units currently does not affect other functions. I am planning to address those separately in a different PR. modules.uncertainity is the only package which has now got functions calling trait.lookup.

Should I include model id as well as a data member in trait ?