Closed Aariq closed 1 year ago
Looks great- just make sure to update the change log!
I can do this, but I'll just point out that the changelog already includes a bullet about this function being re-factored for this version. This bug was an unforseen side-effect of that refactoring
Description
Fixes #3012 . Checks if argument
x
is difftime, and if it is converts it to aunits
object withas_units()
. Units are inferred from the class, so argumentu1
isn't actually used in the conversion in this case. UI is a little weird here, but seems like this is mostly an internal function so probably better than adding argument defaults and allowingu1
to beNULL
or something like that.Motivation and Context
Review Time Estimate
Types of changes
Checklist: