Closed allgandalf closed 10 months ago
I think the "expected" tests are ones that are removed in this PR -- I believe a repo admin will need to go into GitHub's branch protection settings and remove those from the list of required tests.
yes, this was done with my last PR for the CI workflow as well 😁, feeling a little guilty over here :sweat_smile:
@mdietze I vote we merge this before any futher changes to CI versions (e.g. #3234) , so that we don't have to change numbers in as many places.
With this PR, we also need to disable the Required checks for check_base (4.1) , check_models (4.1) , check_modules (4.1)
as they are renamed in this PR, repo admin should be able to do this .
Description
Referencing to the issue #3194, this PR aims to reduce the code duplication by setting the check command variables as Matrix variables.
Motivation and Context
After the first CI optimization PR, there was a little discussion by @infotroph that we cloud use matrix variables to reduce the code duplication which occurs in the current code.
Review Time Estimate
Types of changes
Checklist: