PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
202 stars 235 forks source link

build: Optimize CI Pipeline Code #3195

Closed allgandalf closed 10 months ago

allgandalf commented 1 year ago

Description

Referencing to the issue #3194, this PR aims to reduce the code duplication by setting the check command variables as Matrix variables.

Motivation and Context

After the first CI optimization PR, there was a little discussion by @infotroph that we cloud use matrix variables to reduce the code duplication which occurs in the current code.

Review Time Estimate

Types of changes

Checklist:

This PR resolves #3194
infotroph commented 1 year ago

I think the "expected" tests are ones that are removed in this PR -- I believe a repo admin will need to go into GitHub's branch protection settings and remove those from the list of required tests.

allgandalf commented 1 year ago

yes, this was done with my last PR for the CI workflow as well 😁, feeling a little guilty over here :sweat_smile:

infotroph commented 10 months ago

@mdietze I vote we merge this before any futher changes to CI versions (e.g. #3234) , so that we don't have to change numbers in as many places.

allgandalf commented 10 months ago

With this PR, we also need to disable the Required checks for check_base (4.1) , check_models (4.1) , check_modules (4.1) as they are renamed in this PR, repo admin should be able to do this .