Closed allgandalf closed 10 months ago
Just to throw out the pros/cons, the obvious disadvantage of this approach is that it is going to roughly double the clock time on all tests.
There is a trade-off between time
and optimization
, I am still insisting to go with optimization as the tests are failing more frequently due to the API rate limit, but again one of the biggest concern is the additional time required :)
This issue is been further discussed in #3210, so closing this one to keep a single medium and source of communication
Description
From what I have observed in GitHub Actions of Pecan repository, the
Docker
workflow takes the most amount of resources in terms of API usage and run time.Proposed Solution
I'm not 100% sure but i think that we should run the
docker
workflow only if theCI
workflow is completed and successfulThis can save us the github action resources and there by reducing the API limit error to a great extent.
Documentation of this featrure can be found here
The basic changes in the docker workflow file would be somewhat like the example below:
I am not sure if there is any downside to this feature or how much negative impact this can have on our current system, so want some suggestions from the community on this proposal.
@robkooper @infotroph @mdietze