PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
199 stars 231 forks source link

Remove rgdal and maptools from data.atmosphere #3228

Closed istfer closed 7 months ago

istfer commented 8 months ago

Description

Per issue #2914 made changes to data.atmosphere. Modified places where rgdal and maptools were used, shouldn't break anything.

Motivation and Context

See #2914. We have to keep downgrading our R versions because of these packages.

Review Time Estimate

Types of changes

Checklist:

istfer commented 8 months ago

Not sure how to resolve CI errors with this one. I ran generate dependencies and suntools is in docker/depends/pecan.depends.R list

document modules/data.atmosphere
  ℹ Updating PEcAn.data.atmosphere documentation
  ℹ Loading PEcAn.data.atmosphere
  Error in load_imports(path) : The package "suntools" is required.
  Calls: <Anonymous> ... load_imports -> deps_check_installed -> check_installed
  Execution halted
  make: *** [Makefile:174: .doc/modules/data.atmosphere] Error 1
  Error: Process completed with exit code 2.