removed rgdal from data.land and data.remote

istfer commented 8 months ago

Description

Per issue https://github.com/PecanProject/pecan/issues/2914 made changes to data.land. It's a very small change, rgdal functions were being used for printing info only.

I just removed rgdal from data.remote DESCRIPTION as well, although there was an require(rgdal) in the extract_NLCD function, no rgdal package function was being used within this function, also seems to be the case in #3222.

Motivation and Context

See https://github.com/PecanProject/pecan/issues/2914.

Review Time Estimate

[X] Immediately
[ ] Within one week
[ ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

istfer commented 8 months ago

I'm guessing CI's API rate limit errors are not something I can fix on my end?

mdietze commented 8 months ago

Nope, you just have to wait for the API to refresh and then try running the ones that failed again

mdietze commented 8 months ago

@istfer the build hit the following errors in check_modules

check modules/data.remote
  2 warnings found in modules/data.remote.
  1 notes found in modules/data.remote.
  Error: Please fix these and resubmit.
  R check of modules/data.remote returned new problems:
  Execution halted
  checking dependencies in R code ... WARNING: '::' or ':::' import not declared from: 'terra'
  checking dependencies in R code ... WARNING: 'library' or 'require' calls not declared from: 'doParallel' 'PEcAn.DB'
  checking dependencies in R code ... WARNING: 'library' or 'require' calls in package code: 'doParallel' 'PEcAn.DB' Please use :: or requireNamespace() instead. See section 'Suggested packages' in the 'Writing R Extensions' manual.

At a minimum, I think you need to remove raster from the DESCRIPTION and add terra. Looks like there are additional issues with 'doParallel' and 'PEcAn.DB' that aren't your fault but may need to be resolved too. For example there's a require(doParallel) in download.thredds.R that we can probably get rid of since the functions appear to be using the namespace. Same with the library(PEcAn.DB) in NLCD.R

PecanProject / pecan