Update write.configs.ed.R

mdietze commented 8 months ago

third straw on isFalse

Description

Motivation and Context

Review Time Estimate

[ ] Immediately
[ ] Within one week
[ ] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Aariq commented 8 months ago

I don't think these errors with xfun::isFALSE() are anything in PEcAn—the error is more likely coming from an old version of rmarkdown or knittr or something (not exactly sure, because Yihui doesn't really say where exactly the error comes from in his blog post). When I've seen this error, I've been able to fix it just by using recent versions of packages. For example, the vignettes for PEcAn.DB are built without error here: https://github.com/Aariq/PEcAn.DB/actions/runs/6641355603/job/18043682007#step:6:42. The vignettes also build locally just fine without throwing this error (if you have reasonably up-to-date packages, I guess).

infotroph commented 5 months ago

Closing since dropping support for R 4.0 seems to have ~fixed this.

PecanProject / pecan