Open Hhh-hyc opened 7 months ago
@Hhh-hyc Yucong congratulations on your first PEcAn PR, thank you for contributing. Let's iterate with the suggested revisions.
@Hhh-hyc wanted to ping you about finishing up this PR, which has been in the queue for a while
R check of models/fates reports the following new problems. Please fix these and resubmit:
checking dependencies in R code ... WARNING
'::' or ':::' import not declared from: ‘ncdf4.helpers’
checking for code/documentation mismatches ... WARNING
Codoc mismatches from documentation object 'met2model.FATES':
met2model.FATES
Code: function(in.path, in.prefix, outfolder, start_date, end_date,
lst = 0, lat, lon, overwrite, verbose)
Docs: function(in.path, in.prefix, outfolder, start_date, end_date,
lst = 0, lat, lon, overwrite = FALSE, verbose = FALSE,
...)
Argument names in docs not in code:
...
Mismatches in argument default values:
Name: 'overwrite' Code: Docs: FALSE
Name: 'verbose' Code: Docs: FALSE
Codoc mismatches from documentation object 'model2netcdf.FATES':
model2netcdf.FATES
Code: function(outdir, sitelat, sitelon, pfts)
Docs: function(outdir)
Argument names in code not in docs:
sitelat sitelon pfts
checking R code for possible problems ... NOTE
model2netcdf.FATES : var_update: no visible global function definition
for ‘show’
Undefined global functions or variables:
show
@Hhh-hyc checking in again on this PR which seems to require fairly minor changes to pass the GH Action checks. Is this something you'll be able to get back to soon?
Description
Changes made in this pull request:
Motivation and Context
Integrate the newest version of CTSM-FATES into PEcAn. CTSM-FATES is assumed to be run in a docker or openshift container. The work is relevant to the issue on PEcAN #1008 and the issue on FATES: NGEET/fates#364
Review Time Estimate
Types of changes
Checklist: