LDNDC integration - update - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

199 stars 231 forks source link

LDNDC integration - update #3242

Closed HenriKajasilta closed 1 month ago

HenriKajasilta commented 7 months ago

Description

A lot of changes compared to the earlier LDNDC push.

It is not anymore fixed to simulate only certain sites with specific inputs
Writes site and species parameters based on the given priors
Can use initial conditions from given source/path
Possible to simulate several grass and crop species
Writes outputs for LAI, several fluxes, soil moistures and biomasses
Expects that driver and event files are given in pecan.xml
Updated the documentation page, which has up-to-date situation of the model integration

Motivation and Context

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

mdietze commented 4 months ago

@HenriKajasilta @istfer wanted to ping y'all about finishing up this PR