PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
199 stars 231 forks source link

Basgra updates including the YASSO SOC model #3265

Closed juliusvira closed 1 month ago

juliusvira commented 4 months ago

Description

This PR adds a new soil organic carbon (SOC) model to the BASGRA grassland model, updates the wrappers, and adds unit tests for the wrappers. The SOC model is an adaptation of the YASSO20 (https://doi.org/10.5194/gmd-15-1735-2022); the user can switch between YASSO20 and the original BASGRA_N SOC model by setting a parameter. The YASSO implementation also includes an experimental nitrogen cycling extension, which can be optionally enabled.

Motivation and Context

The modifications to BASGRA provide an option to choose a more detailed SOC model when needed.

Review Time Estimate

Types of changes

Checklist:

infotroph commented 1 month ago

Sorry for the long wait on this. @istfer @juliusvira is this ready to merge as soon as tests pass?

mdietze commented 1 month ago

@juliusvira @istfer would love to get this PR in. It appears that @infotroph has submitted a PR to @juliusvira branch of pecan with some fixes that should resolve the GH Actions warnings. Could you pull that in? That should update this PR and then we should be good to go!