Fix file extension search in met2model.SIPNET function - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

199 stars 230 forks source link

Fix file extension search in met2model.SIPNET function #3281

Closed Sweetdevil144 closed 3 months ago

Sweetdevil144 commented 3 months ago

Description

Fix file extension search in met2model.SIPNET function
Update R-lib actions to use v2 wherever required
Motivation and Context

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x] When possible

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

allgandalf commented 3 months ago

Just a little advice for the long run @Sweetdevil144 , keep PR title a little more descriptive, this helps a lot when we revisit the changes made to files in any PR, for example: [Fix]: Change module version from master to v2 (On similar lines), this helps a lot. You can also refer: https://github.blog/2015-01-21-how-to-write-the-perfect-pull-request/

:clinking_glasses: