PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
199 stars 230 forks source link

Reusable action workflows #3285

Closed infotroph closed 1 month ago

infotroph commented 2 months ago

Description

Avoids repeating ourselves by defining the test/check/sipnet workflows once and calling them from both the on-push and the weekly Actions.

Motivation and Context

Review Time Estimate

Types of changes

Checklist:

allgandalf commented 2 months ago

Ahh, finally breaking down our CI into subparts, Will get to review this week, but okay if @robkooper finishes it before me :)

allgandalf commented 1 month ago

From the logs, the docker failure seems unrelated, can you merge main @infotroph , lets see if the docker passes now

infotroph commented 1 month ago

we need to make certain workflows as required

~I don't think this PR will change anything there -- we've effectively kept the same workflows under the same names, but moved their definitions out to another file. @GandalfGwaihir do you see changes needed that I missed here?~

Edit: I see what you mean now -- turns out GitHub labels them differently even when we don't change the names. Yes, I'll handle this on merge.