search

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
199 stars 230 forks source link

Incomplete Code in `met2CF.R` #3289

Closed Sweetdevil144 closed 1 month ago

Sweetdevil144 commented 1 month ago

Bug Description

The active file met2CF.R is incomplete. Some variables are not defined and the function dbfile.input.insert is not completed.

The code file was last changed 10 years ago.

To Reproduce

Steps to reproduce the behavior:

  1. Open the file modules/data.atmosphere/inst/scripts/met2CF.R
  2. Scroll down to lines 54
  3. Observe the incomplete code

Expected behavior

The file met2CF.R should contain complete R code. It is observed that the end code block is missing as follow :

  # insert into db as input
dbfile.input.insert <- function(filename, siteid, startdate, enddate, mimetype, formatname, con, hostname=PEcAn.remote::fqdn()) {

Screenshots

Screenshot 2024-05-07 at 4 19 24 PM

If applicable, add screenshots to help explain your problem.

Machine (please complete the following information):

Additional context

The incomplete code may be causing issues with the execution of the program. The missing variables and incomplete function need to be defined and completed respectively.

mdietze commented 1 month ago

This script isn't used and can be deleted. Has been superseded by met2CF.csv.R and met2CF.nc.R