Add test suites for `met2Cf.csv.R` - Githubissues

PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.

www.pecanproject.org

Other

199 stars 230 forks source link

Add test suites for `met2Cf.csv.R` #3301

Closed Sweetdevil144 closed 3 weeks ago

Sweetdevil144 commented 1 month ago

Description

This PR introduces the now-Updated test.met2CF.csv.R. Following changes were made:

Format parameters were Updated as they were long outdated with time.
Added a test suite to check if successful conversion takes place.

Motivation and Context

Fixes #202

Screenshot 2024-05-31 at 1 21 07 PM

Review Time Estimate

[ ] Immediately
[ ] Within one week
[x] When possible

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] My name is in the list of CITATION.cff
[ ] I have updated the CHANGELOG.md.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

mdietze commented 1 month ago

looks good to me but leaving final 👍 to @infotroph or @moki1202