PecanProject / pecan

The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.
www.pecanproject.org
Other
199 stars 230 forks source link

build depends fresh if no existing tag to update #3314

Closed infotroph closed 5 days ago

infotroph commented 6 days ago

(moved from robkooper#82)

Should fix Docker build failure in release branch that arises because the existing code tries to test-build the depends image by updating an existing pecan/depends:<base branch> and we (1) don't have a depends:master (we were calling it depends:latest), and (2) if we did, it would usually be so out of date it makes more sense to build a fresh image than to update it.

This was one of two approaches I proposed. See https://github.com/robkooper/pecan/pull/79 for the other and speak up if you like that better, but I now prefer this one.

Note that this will change behavior of non-PR calls to the Docker action:

Status quo:

robkooper#79

This PR:

Invariant across all 3 approaches: Runs with no dependency changes do not build depends, whether or not they're a PR.