PeculiarVentures / PKI.js

PKI.js is a pure JavaScript library implementing the formats that are used in PKI applications (signing, encryption, certificate requests, OCSP and TSP requests/responses). It is built on WebCrypto (Web Cryptography API) and requires no plug-ins.
http://pkijs.org
Other
1.25k stars 204 forks source link

Fix bug in verifySCTsForCertificate #359

Closed bdehamer closed 1 year ago

bdehamer commented 1 year ago

Fix bug in SignedCertificateTimestamp.ts which results in an invalid signature value being passed to crypto.verifyWithPublicKey.

When the signature object is constructed the value is set to a property named: valueHex, but when it is accessed in the CryptoEngine it is accessed via valueHexView -- since that property doesn't exist, the signature is undefined.

Closes https://github.com/PeculiarVentures/PKI.js/issues/358

coveralls commented 1 year ago

Coverage Status

Coverage increased (+1.03%) to 74.291% when pulling 036933745ae6c3ae4d57a265f787f847e72e3aef on bdehamer:master into 54966e88bf4014d791646a986879f4d2336235b0 on PeculiarVentures:master.

microshine commented 1 year ago

The new version pkijs@3.0.6 has been published

@bdehamer thank you for your update