PeculiarVentures / fortify-tools

Fortify enables web applications to use smart cards, local certificate stores and do certificate enrollment. This is the "Tool" application used in the Fortify desktop application.
https://tools.fortifyapp.com
MIT License
15 stars 7 forks source link

Need add sorting on Type #176

Closed OlhaPeculiar closed 3 months ago

OlhaPeculiar commented 3 months ago
image
OleksandrSPV commented 3 months ago

@OlhaPeculiar Related to https://github.com/orgs/PeculiarVentures/projects/9/views/1?pane=issue&itemId=61553399

donskov commented 3 months ago

@OleksandrSPV I do not see any connection with the tasks that you have attached. Sorting does not depend on it.

OleksandrSPV commented 3 months ago

There is only one type of certificate in list, I mean should we add this sorting by type now or we will add it when we have support for scr in list. What do you think? @donskov @OlhaPeculiar

donskov commented 3 months ago

@OleksandrSPV Let's add it now and close the task there.

OleksandrSPV commented 3 months ago

@OleksandrSPV Let's add it now and close the task there.

Ok, I'll do. @donskov

OleksandrSPV commented 3 months ago

@donskov here is a PR https://github.com/PeculiarVentures/fortify-tools/pull/181

donskov commented 3 months ago

@OleksandrSPV Only the @OlhaPeculiar can close the issue because she needs to test it again.

OleksandrSPV commented 3 months ago

@OleksandrSPV Only the @OlhaPeculiar can close the issue because she needs to test it again.

Olga already tested it on https://fortify-tools-2-oleksandrspv-oleksandrspvs-projects.vercel.app and told me that all works fine @donskov