search

PeculiarVentures / peculiar-react-components

https://peculiarventures.github.io/peculiar-react-components/
MIT License
2 stars 3 forks source link

Drop extra forwardRef usage for Portal component #100

Closed WorldThirteen closed 2 years ago

WorldThirteen commented 2 years ago

Fix https://github.com/PeculiarVentures/peculiar-react-components/issues/99. We want this to be fixed, to reduce extra warns on our projects that still used this package and those which could not migrate to https://github.com/PeculiarVentures/peculiar-ui in the near time.

This PR does change any public API since forwardRef feature was not actually used inside the Portal implementation. React.Fragment needed only for react-docgen to keep seeing Portal as a component to work correctly at docs site.

BUT, I need help since lint crashed due to its update and not due to my code. Same for tests, it failed due to some weird reason not related to changes in PR.

donskov commented 2 years ago

@WorldThirteen Please validate the changes.

WorldThirteen commented 2 years ago

@donskov, it works perfectly, thank you. You are simply the best 🎉!

donskov commented 2 years ago 
Successfully published:
 - lib-react-components@3.0.2