search

PeculiarVentures / peculiar-react-components

https://peculiarventures.github.io/peculiar-react-components/
MIT License
2 stars 3 forks source link

Fix switch label paddings #106

Closed troyqa closed 2 years ago

troyqa commented 2 years ago

There's padding difference at switch label between current Peculiar React Components and Hancock mockup.

current Screenshot 2022-08-22 at 14 47 52
mockup Screenshot 2022-08-22 at 14 51 16

My suggestion is to change padding-left and padding-right from 20px to 10px at switch_label position left/right.

I have analyzed and found no situations where it could affect other components

WorldThirteen commented 2 years ago

I don't think it safe to make such a global update, since these components might be used for different projects. I'd like to recommend fix it in place for your issue and your project. This library is a public project with a kind of design system, so it should not fit some specific mockup of your project.

So I'd like to close this issue as not planned. cc @donskov.

donskov commented 2 years ago

You are right @WorldThirteen. I also don't want to make these changes now because of the threat of breaking something in other projects.

Close!