search

PeculiarVentures / peculiar-react-components

https://peculiarventures.github.io/peculiar-react-components/
MIT License
2 stars 3 forks source link

Portal missing ref usage in forwardRef which results in warns #99

Closed WorldThirteen closed 2 years ago

WorldThirteen commented 3 years ago

https://github.com/PeculiarVentures/peculiar-react-components/blob/9ed90f39968993a6a3db3fd7f6d94345adaebdc2/packages/components/src/containers/portal/index.jsx#L15

Warns:

Warning: forwardRef render functions accept exactly two parameters: props and ref. Did you forget to use the ref parameter?

It is also possible that such style of forwardRef usage also may be a reason: https://github.com/PeculiarVentures/peculiar-react-components/blob/6ce897913606138d835e132272268f7409003ded/packages/components/src/containers/analytics_hoc/index.jsx#L30