search

PeculiarVentures / webcrypto-core

A input validation layer for WebCrypto polyfills.
MIT License
28 stars 13 forks source link

25519 #12

Closed microshine closed 6 years ago

microshine commented 7 years ago

@rmhrisk I added new 25519 named curve to ECDSA and ECDH. It must be not correct for real curve names. For example elliptic uses other names for it

Should I change names for namedCurve?

Current version

ECDSA 25519 key generation

crypto.subtle.generateKey(
    {
        name: "ECDSA",
        namedCurve: "25519"
    },
    false,
    ["sign", "verify"],
)

ECDH 25519 key generation

crypto.subtle.generateKey(
    {
        name: "ECDH",
        namedCurve: "25519"
    },
    false,
    ["deriveBits", "deriveKey"],
)
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.003%) to 97.418% when pulling 73f79ef32f39da2afa59edae8922324613f757e6 on 25519 into 560571cc1884843f8fbcf489fa3b4646037b7ea6 on master.

rmhrisk commented 7 years ago

ed25510 is signing - https://ed25519.cr.yp.to/ Curve25510 is dh - https://cr.yp.to/ecdh.html

microshine commented 6 years ago

This PR is not actual. master branch supports X25519 namedCurve