search

PeculiarVentures / webcrypto-core

A input validation layer for WebCrypto polyfills.
MIT License
28 stars 13 forks source link

Ed25519 ChaCha20 Poly1305 #15

Closed Mischala closed 5 years ago

Mischala commented 5 years ago

Adddong Ed25519, ChaCha20 and Poly11305 to bring webcrypto-core in line with RFC7539

I plan to implement these downstream in webcrypto-liner, for use in js-jose

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 97.684% when pulling 5d5ffcb32a4a86938ced7d2c75eaf87a8c300785 on Mischala:Ed25519Chacha20Poly11305 into c8348c515301ca37f6698f22b9a066917196f062 on PeculiarVentures:master.

microshine commented 5 years ago

@Mischala thank you for you PR and work you did.

I'm not sure about X25519 algorithm. Current version supports X25519 via Ecdh provider. We need to decide which variant to stay. @rmhrisk what do you think?

Mischala commented 5 years ago

@microshine oh i was not aware X25519 was already implemented. I am happy to remove that addition if X25519 key generation and derivation is already possible. no point in including two ways to do the same thing.

Mischala commented 5 years ago

I believe this is all ready to merge. I do not have permissions to do so.

rmhrisk commented 5 years ago

@microshine please review and merge as appropriate.

Mischala commented 5 years ago

Hey, any news on this? would like to get this merged so I can implement these ciphers downstream.

microshine commented 5 years ago

Sorry for delay. Thank you for your update and PR

microshine commented 5 years ago

I've published new version of webcrypto-core v0.1.24