Parsing an x509 returns 'Cannot convert ASN.1 algorithm to WebCrypto algorithm'

pizzasaurusrex commented 3 years ago

I'm hoping to get some info on an error I'm running into when parsing a certificate using new x509.X509Certificate(). When I try to parse the below cert it throws an error Cannot convert ASN.1 algorithm to WebCrypto algorithm' - per the code this looks expected. but I was able to parse this with pkijs and `asn1js' I'm just wondering if this is intended or if there's a workaround.

cert:

microshine commented 3 years ago

It occurs cause @peculiar/x509 doesn't support DSA algorithm and your certificate's public key is DSA. It's possible to extend the module in runtime by adding DSAAlgorithm provider (see ED algorithm)

But maybe it would be better don't throw an exception on parsing and return UnknownAlgorithm for such cases

interface UnknownAlgorithm {
  name: string; // 1.2.840.10040.4.1
  params?: ArrayBuffer | null;
}

microshine commented 3 years ago

I'll update the module today

microshine commented 3 years ago

@pizzasaurusrex Please try @peculiar/x509@1.3.0

pizzasaurusrex commented 3 years ago

@microshine that fixed it, thank you !

PeculiarVentures / x509

Parsing an x509 returns 'Cannot convert ASN.1 algorithm to WebCrypto algorithm' #6