PedalPi / PluginsManager

Pythonic management of LV2 audio plugins with mod-host
http://pedalpi-pluginsmanager.readthedocs.io/
Apache License 2.0
12 stars 5 forks source link

Update "UpdatesObserver" methods signatures #12

Closed SrMouraSilva closed 7 years ago

SrMouraSilva commented 7 years ago
    ADD index, origin
    def on_bank_updated(self, bank, update_type, **kwargs):
        """
        Called when changes occurs in any :class:`Bank`

        :param Bank bank: Bank changed.
        :param UpdateType update_type: Change type
        :param int index: Bank index (or old index if update_type == UpdateType.DELETED)
        :param BanksManager origin: BanksManager that the bank is (or has) contained
        """
        pass

    ADD index, origin
    def on_pedalboard_updated(self, pedalboard, update_type, **kwargs):
        """
        Called when changes occurs in any :class:`Pedalboard`

        :param Pedalboard pedalboard: Pedalboard changed
        :param UpdateType update_type: Change type
        :param int index: Pedalboard index (or old index if update_type == UpdateType.DELETED)
        :param Bank origin: Bank that the pedalboard is (or has) contained
        """
        pass

    ADD index, origin
    def on_effect_updated(self, effect, update_type, **kwargs):
        """
        Called when changes occurs in any :class:`Effect`

        :param Effect effect: Effect changed
        :param UpdateType update_type: Change type
        :param int index: Effect index (or old index if update_type == UpdateType.DELETED)
        :param Pedalboard origin: Pedalboard that the effect is (or has) contained
        """
        pass

    OK
    def on_effect_status_toggled(self, effect):
        """
        Called when any :class:`Effect` status is toggled

        :param Effect effect: Effect when status has been toggled
        """
        pass

    OK
    def on_param_value_changed(self, param):
        """
        Called when a param value change

        :param Param param: Param with value changed
        """
        pass

    OK
    def on_connection_updated(self, connection, update_type):
        """
        Called when changes occurs in any :class:`pluginsmanager.model.connection.Connection` of Pedalboard
        (adding, updating or removing connections)

        :param pluginsmanager.model.connection.Connection connection: Connection changed
        :param UpdateType update_type: Change type
        """
        pass
SrMouraSilva commented 7 years ago

I will not do it for the sake of enabling a (mal) incremental method parameters in the future